Skip to content

Conversation

@on3iro
Copy link

@on3iro on3iro commented Feb 21, 2023

Hi @delucis ,

I just recently discovered this awesome plugin, but soon realized, that its build and docs have not yet been upgraded to the latest boardgame.io version.
Therefore I tried to incorporate the necessary changes. I hope I did not forget anything.
Just let me know if this works for you or if I should change anything.
Oh and if you don't intend to update this to bgio v50, we should probably at least note this somewhere in the docs.

On a side note: I am not sure, yet, but I assume there are also a few outdated boardgame.io docs, that do not match the new v50 types. I also noticed that the boardgame.io documentation seems to take really long to load in the last couple of days.

@fladrif
Copy link

fladrif commented Mar 22, 2025

Can the change from single quote to double quotes be left out? A style change should probably be in a separate MR

@fladrif
Copy link

fladrif commented Mar 22, 2025

Otherwise, changes LGTM

@@ -0,0 +1 @@
v18.12.1
Copy link

@fladrif fladrif Mar 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we want to include this file either. This doesn't necessarily lock people into using nvm, but I personally don't and I don't think every maintainer should start adding their specific tooling configuration

@on3iro
Copy link
Author

on3iro commented Mar 23, 2025

@fladrif hey thanks for the review. Unfortunately I currently don't have any spare time to continue working on this and also haven't used bgio in quite some time. Feel free to use this PR as a baseline.

Regarding the issues you mentioned:

  1. The singe/double quotes issue likely stems from me having prettier configured and because there's no prettier config saving a file will automatically lead to prettiers default behavior. So the easiest way to fix this would probably either be to throw away these changes or to add a prettier config and let it run against the project. For me personally having a prettier config in a js/ts project is (especially open source) is a must, as it ensures consistency across contributions (though it might need CI or at least commit hooks)
  2. .nvmrc I also think that having some form of proper node versioning would probably be helpful to clearly communicate which node version the project has been run and tested against. There's also a node-version file irrc. Alternatively you could specify the engines property inside the package.json this should also help.

@fladrif
Copy link

fladrif commented Mar 24, 2025

@on3iro Gotcha, I'll do that. Thanks for getting the ball rolling on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants